Fix linux install checks

Env variables are in the wrong place, node20 issue
koordinates · Sep 5, 2024 · 76944f4 · 76944f4
1 parent 4893428
commit 76944f4
Showing 1 changed file with 13 additions and 11 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -90,7 +90,7 @@ jobs:
           - 3306:3306
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
 
@@ -99,7 +99,7 @@ jobs:
       #
 
       - name: "setup: cmake & ninja"
-        uses: lukka/get-cmake@v3.25.2  # workaround for node 20 issue
+        uses: lukka/get-cmake@latest
         with:
           cmakeVersion: "${{ env.CMAKE_VERSION }}"
 
@@ -319,15 +319,15 @@ jobs:
         PATH: "/opt/python/cp311-cp311/bin:/opt/rh/devtoolset-10/root/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/github/home/.cargo/bin:/opt/mssql-tools/bin"
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
 
       #
       # setup
       #
       - name: "setup: cmake & ninja"
-        uses: lukka/get-cmake@v3.25.2  # workaround for node 20 issue
+        uses: lukka/get-cmake@latest
         with:
           cmakeVersion: "${{ env.CMAKE_VERSION }}"
 
@@ -545,15 +545,17 @@ jobs:
     name: "Install-check: ${{ matrix.os.label }}/${{ matrix.arch.label }}"
     continue-on-error: ${{ !!matrix.os.xfail }}
 
+    env:
+      ACTIONS_RUNNER_FORCE_ACTIONS_NODE_VERSION: node16
+      ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
+
     container:
       image: ${{ matrix.os.image }}
       credentials:
         username: ${{ needs.amazon-ecr-auth.outputs.docker_username }}
         password: ${{ needs.amazon-ecr-auth.outputs.docker_password }}
       env:
         DEBIAN_FRONTEND: noninteractive
-        ACTIONS_RUNNER_FORCE_ACTIONS_NODE_VERSION: node16
-        ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
 
     steps:
       - name: setup
@@ -608,7 +610,7 @@ jobs:
           command -v kart
           kart --version
 
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: e2e test (no helper)
         env:
@@ -647,7 +649,7 @@ jobs:
       PY_VER_ID: "cp311-cp311"
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
 
@@ -663,7 +665,7 @@ jobs:
           cache-dependency-path: 'requirements/*.txt'
 
       - name: "setup: cmake & ninja"
-        uses: lukka/get-cmake@v3.25.2  # workaround for node 20 issue
+        uses: lukka/get-cmake@latest
         with:
           cmakeVersion: "${{ env.CMAKE_VERSION }}"
 
@@ -784,7 +786,7 @@ jobs:
       PY_VER_INSTALLER: "https://www.python.org/ftp/python/3.11.6/python-3.11.6-macos11.pkg"
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
 
@@ -1042,7 +1044,7 @@ jobs:
       )
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: recursive