Add GPKG application ID to GPKG working copies #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsen232
force-pushed
the
gpkg-application-id
branch
from
e7c3eac
to
4a94ff1
Compare
craigds
approved these changes
Aug 28, 2023
olsen232
force-pushed
the
gpkg-application-id
branch
from
4a94ff1
to
b00c454
Compare
macos build is flaky, might be hard to tell if its fixed
olsen232
force-pushed
the
gpkg-application-id
branch
from
b00c454
to
97767f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #902
GPKG working copies written by kart currently are missing the GPKG application ID, which means they are not spec conformant.
Not yet aware of any clients that are affected by this, but we should conform to spec. Now we do:
Checklist: