logger v2 #7
logger v2 #7
Conversation
WalkthroughThe recent update introduces a new logging system to enhance logging capabilities project-wide. This system brings in configurable log levels, formats, and file creation, aiming to streamline log handling for improved debugging and monitoring tailored to diverse developmental needs. Changes
Poem
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
internal/logger/logger_utils.go
Outdated
| func Initialize(cfg Config) { | ||
| config = cfg | ||
| logrus.SetFormatter(config.LogFormat) | ||
| switch config.LogLevel { | ||
| case InfoLevel: | ||
| logrus.SetLevel(logrus.InfoLevel) | ||
| case WarnLevel: | ||
| logrus.SetLevel(logrus.WarnLevel) | ||
| case ErrorLevel: | ||
| logrus.SetLevel(logrus.ErrorLevel) | ||
| default: | ||
| logrus.SetLevel(logrus.InfoLevel) | ||
| } | ||
|
|
||
| for _, file := range config.ModuleToFile { | ||
| path := filepath.Dir(file) | ||
| if err := os.MkdirAll(path, os.ModePerm); err != nil { | ||
| logrus.WithError(err).Fatal("cannot create log directory") | ||
| } | ||
| file, err := os.OpenFile(file, os.O_CREATE|os.O_WRONLY|os.O_APPEND, 0666) | ||
| if err != nil { | ||
| logrus.WithError(err).Fatal("cannot open log file") | ||
| } | ||
|
|
||
| logrus.SetOutput(file) | ||
| } | ||
| } |
There was a problem hiding this comment.
The logger output is set to the last file in the loop, which likely causes all logs to be written to the same file.
- logrus.SetOutput(file)
+ logger.SetOutput(file) // Ensure each logger instance has its correct output file.Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| func Initialize(cfg Config) { | |
| config = cfg | |
| logrus.SetFormatter(config.LogFormat) | |
| switch config.LogLevel { | |
| case InfoLevel: | |
| logrus.SetLevel(logrus.InfoLevel) | |
| case WarnLevel: | |
| logrus.SetLevel(logrus.WarnLevel) | |
| case ErrorLevel: | |
| logrus.SetLevel(logrus.ErrorLevel) | |
| default: | |
| logrus.SetLevel(logrus.InfoLevel) | |
| } | |
| for _, file := range config.ModuleToFile { | |
| path := filepath.Dir(file) | |
| if err := os.MkdirAll(path, os.ModePerm); err != nil { | |
| logrus.WithError(err).Fatal("cannot create log directory") | |
| } | |
| file, err := os.OpenFile(file, os.O_CREATE|os.O_WRONLY|os.O_APPEND, 0666) | |
| if err != nil { | |
| logrus.WithError(err).Fatal("cannot open log file") | |
| } | |
| logrus.SetOutput(file) | |
| } | |
| } | |
| func Initialize(cfg Config) { | |
| config = cfg | |
| logrus.SetFormatter(config.LogFormat) | |
| switch config.LogLevel { | |
| case InfoLevel: | |
| logrus.SetLevel(logrus.InfoLevel) | |
| case WarnLevel: | |
| logrus.SetLevel(logrus.WarnLevel) | |
| case ErrorLevel: | |
| logrus.SetLevel(logrus.ErrorLevel) | |
| default: | |
| logrus.SetLevel(logrus.InfoLevel) | |
| } | |
| for _, file := range config.ModuleToFile { | |
| path := filepath.Dir(file) | |
| if err := os.MkdirAll(path, os.ModePerm); err != nil { | |
| logrus.WithError(err).Fatal("cannot create log directory") | |
| } | |
| file, err := os.OpenFile(file, os.O_CREATE|os.O_WRONLY|os.O_APPEND, 0666) | |
| if err != nil { | |
| logrus.WithError(err).Fatal("cannot open log file") | |
| } | |
| logger.SetOutput(file) // Ensure each logger instance has its correct output file. | |
| } | |
| } |
Summary by CodeRabbit