Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#578] Adds inspections for partial Scientific functions #579

Merged

Conversation

jlavelle
Copy link
Contributor

@jlavelle jlavelle commented Dec 3, 2024

I added four new inspections, all relating to functions on Scientific from the scientific package that are partial due to potentially repeating decimals:

  • STAN-0022 fromRational :: Rational -> Scientific
  • STAN-0023 realToFrac :: Real a => a -> Scientific
  • STAN-0024 recip :: Scientific -> Scientific
  • STAN-0025 (/) :: Scientific -> Scientific -> Scientific

I added four new inspections, all relating to functions on `Scientific`
from the `scientific` package that are partial due to potentially
repeating decimals:

- STAN-0022 `fromRational :: Rational -> Scientific`
- STAN-0023 `realToFrac :: Real a => a -> Scientific`
- STAN-0024 `recip :: Scientific -> Scientific`
- STAN-0025 `(/) :: Scientific -> Scientific -> Scientific`
@tomjaguarpaw tomjaguarpaw merged commit 386a5ef into kowainik:main Dec 4, 2024
26 checks passed
@tomjaguarpaw
Copy link
Collaborator

Thank you! Looks great. I'll aim to release this at the same time as I update stan for the forthcoming release of GHC 9.12, but if you really need a release beforehand (for example, because building it yourself from source isn't sufficient for your needs) then please do open an issue to let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants