Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite apps installation script #7

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

l1storez
Copy link

Should I change the name of the branch because I forgot about the prefix "feature"?
I'll fix the syntax error later

@l1storez
Copy link
Author

I will add apps later too

@l1storez l1storez force-pushed the rewrite-apps-installation-script branch from 388a8a7 to 3825b5e Compare August 29, 2022 14:33
@l1storez l1storez force-pushed the rewrite-apps-installation-script branch from 3825b5e to 3de9bf7 Compare August 29, 2022 14:53
@l1storez
Copy link
Author

I remove 365fb6e in accordance to https://github.com/kpi-web-guild/devspace/pull/6/files#r314916295 or is it better for me to fix the commit and add installation script to the correct place?

@l1storez l1storez requested a review from webknjaz August 29, 2022 15:01
@webknjaz
Copy link
Member

webknjaz commented Sep 9, 2022

I remove 365fb6e in accordance to #6 (files) or is it better for me to fix the commit and add installation script to the correct place?

Instead of just removing it, you should move it to a playbook. If you just exclude the commit from rebase, you'd forget about re-adding it elsewhere. An atomic thing to do is to have a commit that drops that file but adds Kitty to the playbook. Alternatively, use git revert so that it's present in the history.

@webknjaz
Copy link
Member

webknjaz commented Sep 9, 2022

Looks like you've broken this commit 3a0ee0a (#7) — it now says that you authored it which is incorrect. Fix this too.

@l1storez
Copy link
Author

l1storez commented Sep 9, 2022

Instead of just removing it, you should move it to a playbook.

Cool! I move it to a playbook. It will be my commit or a co-author's commit?

@l1storez
Copy link
Author

l1storez commented Sep 9, 2022

Looks like you've broken this commit 3a0ee0a (#7) — it now says that you authored it which is incorrect. Fix this too.

Yep. but I delete 'main.workflow' and 'inventory' from this commit. It will be co-authored or not mine? I mean, I'm changing more than half if not all of this commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants