-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite apps installation script #7
base: master
Are you sure you want to change the base?
Conversation
I will add apps later too |
388a8a7
to
3825b5e
Compare
3825b5e
to
3de9bf7
Compare
I remove 365fb6e in accordance to https://github.com/kpi-web-guild/devspace/pull/6/files#r314916295 or is it better for me to fix the commit and add installation script to the correct place? |
Instead of just removing it, you should move it to a playbook. If you just exclude the commit from rebase, you'd forget about re-adding it elsewhere. An atomic thing to do is to have a commit that drops that file but adds Kitty to the playbook. Alternatively, use |
Looks like you've broken this commit |
Cool! I move it to a playbook. It will be my commit or a co-author's commit? |
Yep. but I delete 'main.workflow' and 'inventory' from this commit. It will be co-authored or not mine? I mean, I'm changing more than half if not all of this commit |
Should I change the name of the branch because I forgot about the prefix "feature"?
I'll fix the syntax error later