fix(github): fix github enterprise authentication

krateoplatformops · Oct 24, 2023 · f1c0cbf · f1c0cbf
1 parent a1f498f
commit f1c0cbf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/controllers/auth/read.auth.controller.js b/controllers/auth/read.auth.controller.js
@@ -140,15 +140,16 @@ router.get('/github/callback', (req, res, next) => {
   userInfo.username = 'userlb'
   userInfo.email = 'myemail'
 
-  logger.debug('8')
-  logger.debug(JSON.stringify(userInfo))
+  logger.info('8')
+  logger.info(JSON.stringify(userInfo))
   const user = authHelpers.cookie(userInfo, 'github')
 
-  logger.debug('9')
-  logger.debug(user)
+  logger.info('9')
+  logger.info(user)
 
   res.cookie(envConstants.COOKIE_NAME, jwtHelpers.sign(user), cookieConstants)
   res.redirect(global.redirect)
+  res.status(200)
 })
 
 router.get(

diff --git a/controllers/user/read.user.controller.js b/controllers/user/read.user.controller.js
@@ -1,5 +1,5 @@
 const express = require('express')
-const logger = require('../../service-library/helpers/logger.helpers')
+// const logger = require('../../service-library/helpers/logger.helpers')
 const router = express.Router()
 
 const {
@@ -10,9 +10,6 @@ const jwtHelpers = require('../../service-library/helpers/jwt.helpers')
 
 router.get('/', async (req, res, next) => {
   try {
-    logger.debug(res)
-    logger.debug(JSON.stringify(res))
-
     if (!res.locals.identity) {
       res.clearCookie(envConstants.COOKIE_NAME, { ...cookieConstants })
       res.status(401).send()