Feature/support explicit laplace kernel #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the Julia nightly build fails. It does not seem to be related to my changes but some of the dependencies fail to compile. |
sbadrian
force-pushed
the
feature/support_explicit_laplace_kernel
branch
from
123f12c
to
d99479c
Compare
Closed
With this change, we can dispatch on Laplace-Type kernels as 'Nothing' is a distinct type (while gamma=0.0 could not be distinguished from a Yukawa-Type solution)
The public interfaces to the Helmholtz operators has been moved to a file helmholtz3d.jl resembling the maxwell.jl file. The right-hand sides now store gamma and not the wavenumber. They now correctly allow to discretize real-valued RHS if gamma is real-valued.
- Alpha factor was missing for double - By shifting some rhs constructors for HH3D into the Helmholtz3D submodule LinearAlgebra package needs to be reloaded
When linear maps are added via '+', a tuple is created. For large DirectProductSpaces, this results in prohibitively long compile times with little benefit since the cost for a matrix-vector product will dominate. Instead, LinearCombinations can be created with vectors and long compile times can be avoided.
sbadrian
force-pushed
the
feature/support_explicit_laplace_kernel
branch
from
d99479c
to
989f285
Compare
|
Shall I merge this? |
|
Thb not a big fan of exporting alpha beta gamma. These don't mean anything to most users I think. |
Thanks for catching this, I'll remove this. (Initially, I thought it was useful for the fast method development, but it is actually unnecessary in this context). |
I removed the export of alpha, beta, gamma and from my view, it is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is not possible to detect static kernels at compile time.
This merge request allows that the gamma parameter of Helmholtz3D and Maxwell operators can be set to the value nothing.
Since the value "nothing" is of type Nothing, this allows to dispatch. This is both useful for the development of kernel-dependent fast methods as well as for a feature implementation of static 2D Laplace operators.
Potentially, such an approach is also useful if we want to handle more general kernels (see equation 3.3 in Sauter-Schwab to get an idea).
In addition, the RHS were changed such that the RHSs also use a gamma parameter. Thus, one can get consistent real-valued discretizations for static or Yukawa-type problems.