Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv-cp: add configMapName value to use your own configmap #52

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

rptaylor
Copy link
Contributor

This adds on to #48 and allows custom configmaps of IP pools to be used, which you can create and manage yourself.

  • add .Values.configMapName, if defined your own custom configmap will be used
  • cosmetic change to configmap name for templating simplicity , no functional impact

Signed-off-by: Ryan Taylor <1686627+rptaylor@users.noreply.github.com>
@rptaylor
Copy link
Contributor Author

rptaylor commented Oct 30, 2024

Test with values:

configMapName: kube-vip-address-pools

result:

I1030 16:20:51.342379       1 provider.go:86] Watching configMap for pool config with name: 'kube-vip-address-pools', namespace: 'kube-
vip'   

Another test using default config:

cm:
  data:
    cidr-default: 192.168.0.200/29

Then it uses the auto-generated configmap:

I1030 16:26:30.248381       1 provider.go:86] Watching configMap for pool config with name: 'kube-vip-cloud-provider', namespace: 'kube
-vip' 

Signed-off-by: Ryan Taylor <1686627+rptaylor@users.noreply.github.com>
@rptaylor rptaylor marked this pull request as ready for review October 30, 2024 16:30
@rptaylor
Copy link
Contributor Author

@thebsdbox this is ready for review/merge. Thanks a lot!

@thebsdbox thebsdbox merged commit a29bdc2 into kube-vip:main Oct 30, 2024
3 checks passed
@rptaylor rptaylor deleted the 20241025-configMapName branch October 30, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants