-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disk-snapshot: support volume group snapshot APIs #1176
disk-snapshot: support volume group snapshot APIs #1176
Conversation
24708a0
to
e0cd772
Compare
e0cd772
to
b51622a
Compare
5fda71e
to
74feccb
Compare
74feccb
to
7c15aef
Compare
438d20f
to
1a3002d
Compare
To compated with single snapshot, groupsnapshot removed the limit of request as the sidecar version bumped to v8.
i will submit another PR to update the logic of single snapshot, after this one is merged. @mowangdk |
11072c4
to
c9f5b5a
Compare
c9f5b5a
to
e5323f8
Compare
e5323f8
to
890c456
Compare
707d6b2
to
e85fb04
Compare
a090933
to
12c25d5
Compare
12c25d5
to
05862c9
Compare
/lgtm VolumeGroupSnapshot is about to release beta, we'll follow up with upstream. kubernetes/enhancements#3476 cc@xing-yang |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlbeeSo, mowangdk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR will:
alibabacloud-disk-group-snapshot
EnableVolumeGroupSnapshots=true
pls test with yaml like:
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
VolumeGroupSnapshot need K8s >= 1.27
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: