Skip to content

Commit

Permalink
Use CRD v1 form
Browse files Browse the repository at this point in the history
kustomize also requires that we specify a namespace here, or else it won't add one
  • Loading branch information
james-callahan committed Dec 23, 2024
1 parent 68ebec1 commit 6919efa
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 14 deletions.
17 changes: 10 additions & 7 deletions config/webhook/ingressclassparams_patch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,13 @@ metadata:
spec:
conversion:
strategy: Webhook
webhookClientConfig:
# this is "\n" used as a placeholder, otherwise it will be rejected by the apiserver for being blank,
# but we're going to set it later using the cert-manager (or potentially a patch if not using cert-manager)
caBundle: Cg==
service:
name: webhook-service
path: /convert
webhook:
clientConfig:
# this is "\n" used as a placeholder, otherwise it will be rejected by the apiserver for being blank,
# but we're going to set it later using the cert-manager (or potentially a patch if not using cert-manager)
caBundle: Cg==
service:
namespace: default
name: webhook-service
path: /convert
conversionReviewVersions: ["v1", "v1beta1"]
3 changes: 3 additions & 0 deletions config/webhook/kustomizeconfig.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ nameReference:
- kind: ValidatingWebhookConfiguration
group: admissionregistration.k8s.io
path: webhooks/clientConfig/service/name
- group: apiextensions.k8s.io
kind: CustomResourceDefinition
path: spec/conversion/webhook/clientConfig/service/name

namespace:
- kind: MutatingWebhookConfiguration
Expand Down
17 changes: 10 additions & 7 deletions config/webhook/targetgroupbindings_patch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,13 @@ metadata:
spec:
conversion:
strategy: Webhook
webhookClientConfig:
# this is "\n" used as a placeholder, otherwise it will be rejected by the apiserver for being blank,
# but we're going to set it later using the cert-manager (or potentially a patch if not using cert-manager)
caBundle: Cg==
service:
name: webhook-service
path: /convert
webhook:
clientConfig:
# this is "\n" used as a placeholder, otherwise it will be rejected by the apiserver for being blank,
# but we're going to set it later using the cert-manager (or potentially a patch if not using cert-manager)
caBundle: Cg==
service:
namespace: default
name: webhook-service
path: /convert
conversionReviewVersions: ["v1", "v1beta1"]

0 comments on commit 6919efa

Please sign in to comment.