Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise page on security groups #3415

Closed
wants to merge 2 commits into from

Conversation

geoffcline
Copy link
Contributor

Description

Revise the description of the security groups page.

Checklist

  • n/a for docs updates

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 2, 2023
@geoffcline
Copy link
Contributor Author

@oliviassss will you review this, please?

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: geoffcline
Once this PR has been reviewed and has the lgtm label, please assign m00nf1sh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (eacb0c3) 55.76% compared to head (b5b2a53) 55.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3415   +/-   ##
=======================================
  Coverage   55.76%   55.76%           
=======================================
  Files         149      149           
  Lines        8827     8827           
=======================================
  Hits         4922     4922           
  Misses       3571     3571           
  Partials      334      334           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/deploy/security_groups.md Outdated Show resolved Hide resolved
docs/deploy/security_groups.md Show resolved Hide resolved
docs/deploy/security_groups.md Outdated Show resolved Hide resolved
docs/deploy/security_groups.md Outdated Show resolved Hide resolved
docs/deploy/security_groups.md Outdated Show resolved Hide resolved
docs/deploy/security_groups.md Outdated Show resolved Hide resolved
docs/deploy/security_groups.md Outdated Show resolved Hide resolved
docs/deploy/security_groups.md Outdated Show resolved Hide resolved
docs/deploy/security_groups.md Outdated Show resolved Hide resolved
docs/deploy/security_groups.md Outdated Show resolved Hide resolved
@geoffcline
Copy link
Contributor Author

Thanks for the feedback @johngmyers ! I'm responding and revising now.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2023
@geoffcline geoffcline closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants