Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-picked commits for patch release v2.6.2 #3436

Merged
merged 12 commits into from
Oct 24, 2023
Merged

Cherry-picked commits for patch release v2.6.2 #3436

merged 12 commits into from
Oct 24, 2023

Conversation

shraddhabang
Copy link
Collaborator

Issue

Cherry-picked the commits for patch release of v2.6.2 from main

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

dims and others added 9 commits October 17, 2023 14:48
@dims @shraddhabang
Stricter dependency/security review
9957185 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@kc9ddi @shraddhabang
Expose ingress configuration options for missing backends (kubernetes…
6735fca 
…-sigs#3342)

* Expose configuration for missing backends

This PR adds command line flags to specify whether the the controller should tolerate missing backend services and actions. If the flags are not specified, the default value will be to tolerate missing backend actions and services (which is the current behavior.)

The code changes here are simply to thread these values through to `enhanced_backend_builder.go`, and rely on them rather than using the `defaultTolerateNonExistentBackendService` and `defaultTolerateNonExistentBackendAction` constant fields. The logic here is already unit tested, so no new tests have been added.

* add new settings to values.yaml
@fad3t @shraddhabang
feat: resolve health check port name for NLB
392d840
@fad3t @shraddhabang
fix: remove service from function args
8fbfd89
@michaelsaah @shraddhabang
don't block TGB reconciliation loop on failed SG ingress reconciliation
119b01e 
the controller performs an SG reconciliation step for all (cluster-wide) SGs gathered from all TGBs during the TGB reconciliation loop, before TG endpoints are reconciled: https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/d177c898ddd86071eecc2fd918d72ebfb0af7892/pkg/targetgroupbinding/resource_manager.go#L139-L141

the way the code is currently written, this means that any failure during SG reconciliation blocks reconciliation of all targets across the whole cluster. such a failure can be caused by something as innocuous as a SG being deleted before the associated TGB is deleted, or a SG being entered on a TGB erroneously. this can easily lead to severe outages if not remediated quickly.

this commit changes the method `reconcileWithIngressPermissionsPerSG` to not exit on a single failed SG ingress reconciliation - instead it will log the offending error and continue through the loop.
@michaelsaah @shraddhabang
group errors, emit one event per reconcile, requeue on failure
477dc96
@michaelsaah @shraddhabang
whitespace
f6adc7d
@michaelsaah @johngmyers @shraddhabang
slice init style suggestion
530abb0 
Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
@git4example @johngmyers @shraddhabang
Change of text "your-cluster-name" (kubernetes-sigs#3152)
8d09b38 
* Change of text "your-cluster-name"

* Update docs/deploy/installation.md

Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>

---------

Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @shraddhabang. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 17, 2023
@oliviassss
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2023
@oliviassss
Copy link
Collaborator

/retest

2 similar comments
@shraddhabang
Copy link
Collaborator Author

/retest

@oliviassss
Copy link
Collaborator

/retest

@oliviassss
Copy link
Collaborator

@shraddhabang, please cherry-pick this commit too: #3392

@oliviassss @shraddhabang
update ci e2e script for cert IDs (kubernetes-sigs#3392)
09f3a46 
* update ci e2e script for cert IDs

* add creation for s3 bucket
M00nF1sh
M00nF1sh approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, shraddhabang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 29b34df into kubernetes-sigs:release-2.6 Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M00nF1sh M00nF1sh M00nF1sh approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@M00nF1sh M00nF1sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@shraddhabang @k8s-ci-robot @oliviassss @M00nF1sh @dims @kc9ddi @fad3t @michaelsaah @git4example