-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helm chart configuration for --aws-vpc-tags argument #3906
base: main
Are you sure you want to change the base?
Conversation
|
Welcome @pinkavaj! |
Hi @pinkavaj. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
57b8beb
to
c5cfd11
Compare
It would be IMHO good to solve #3889 before this is considered to be merged. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pinkavaj The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue
#3904 (not solves the --aws-vpc-tag-key part due to #3889)
Description
Add the configuration options to helm chart
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯