-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Cannot set the IPv6 addresses in dualstack mode during modification #3959
base: main
Are you sure you want to change the base?
Conversation
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shraddhabang, wweiwei-li, zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3959 +/- ##
===========================================
+ Coverage 18.20% 49.94% +31.74%
===========================================
Files 175 205 +30
Lines 29280 12115 -17165
===========================================
+ Hits 5330 6051 +721
+ Misses 23584 5648 -17936
- Partials 366 416 +50 ☔ View full report in Codecov by Sentry. |
ping |
Issue
#3743
Description
dualstack
with a provided list of IPv6 addresses. The update is not being reflected because we only check if the subnets ID has changed.-->
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯