-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Fixing kubetest warnings for deprecations #10172
Conversation
Signed-off-by: muhammad adil ghaffar <muhammad.adil.ghaffar@est.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 6402155b3f98eee2539b758273da002be79c8ee1
|
/test |
@fabriziopandini: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-e2e-conformance-main |
by looking at the output of the conformance test it seems that also one of the new flags (slow-spec-threshold) is now deprecated
but we can take care care of this in a follow up |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@adilGhaffarDev : this made the following periodics fail: |
I am checking |
I think when running kubetest we just pass down the arguments. Older versions of the kubetest images we use (depends on k8s version) might have a too old ginkgo version. |
yes that is the issue, I don't see
I will revert |
@chrischdi I have created the PR: #10214 please check. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #10171
/area testing