Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.5] 🐛Don't use v1alpha3 in clusterctl upgrade test #9412

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Sep 13, 2023

This is a partial backport of commit 5c4ce8b.

What this PR does / why we need it:
The clusterctl upgrade test explicitly uses api version v1alpha3 to check for machine readiness, but this version is no longer served by CAPI 1.5. This means that the test now requires the 'before' version to be <1.5. While this doesn't impact the use of the clusterctl upgrade tests in CAPI itself, which explicitly tests upgrades from 1.3 and 1.4, but not 1.5, it does impact use by providers who are also running this test.

Which issue(s) this PR fixes:
Fixes #9411

/area testing

This is a partial backport of commit 5c4ce8b.
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Sep 13, 2023
@k8s-ci-robot k8s-ci-robot added area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 13, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - let's run the tests to be sure.

/test

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-release-1-5
  • /test pull-cluster-api-e2e-release-1-5
  • /test pull-cluster-api-test-release-1-5
  • /test pull-cluster-api-verify-release-1-5

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-release-1-5
  • /test pull-cluster-api-e2e-full-dualstack-and-ipv6-release-1-5
  • /test pull-cluster-api-e2e-full-release-1-5
  • /test pull-cluster-api-e2e-informing-release-1-5
  • /test pull-cluster-api-e2e-mink8s-release-1-5
  • /test pull-cluster-api-e2e-scale-release-1-5-experimental
  • /test pull-cluster-api-e2e-workload-upgrade-1-27-1-28-release-1-5
  • /test pull-cluster-api-test-mink8s-release-1-5

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-release-1-5
  • pull-cluster-api-build-release-1-5
  • pull-cluster-api-e2e-informing-release-1-5
  • pull-cluster-api-e2e-release-1-5
  • pull-cluster-api-test-release-1-5
  • pull-cluster-api-verify-release-1-5

In response to this:

Thanks - let's run the tests to be sure.

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor

/test pull-cluster-api-e2e-full-release-1-5

@mdbooth
Copy link
Contributor Author

mdbooth commented Sep 13, 2023

/test pull-cluster-api-test-release-1-5

Looks like a flake.

Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mdbooth!

I will defer to what CI thinks, otherwise LGTM.

@sbueringer sbueringer changed the title 🐛Don't use v1alpha3 in clusterctl upgrade test [release-1.5] 🐛Don't use v1alpha3 in clusterctl upgrade test Sep 13, 2023
@sbueringer
Copy link
Member

sbueringer commented Sep 13, 2023

/lgtm

Fine to merge for me after green e2e-full

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8cad5b7abe9488771c99f08030caa566ca901554

@mdbooth
Copy link
Contributor Author

mdbooth commented Sep 13, 2023

/lgtm

Fine to merge for me after green e2e-full

e2e-full is green.

@sbueringer
Copy link
Member

Thx!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit f48da89 into kubernetes-sigs:release-1.5 Sep 13, 2023
14 checks passed
@mdbooth mdbooth deleted the v1alpha3-tests branch September 13, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants