-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.5] 🐛Don't use v1alpha3 in clusterctl upgrade test #9412
[release-1.5] 🐛Don't use v1alpha3 in clusterctl upgrade test #9412
Conversation
This is a partial backport of commit 5c4ce8b.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - let's run the tests to be sure.
/test
@killianmuldoon: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-e2e-full-release-1-5 |
/test pull-cluster-api-test-release-1-5 Looks like a flake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mdbooth!
I will defer to what CI thinks, otherwise LGTM.
/lgtm Fine to merge for me after green e2e-full |
LGTM label has been added. Git tree hash: 8cad5b7abe9488771c99f08030caa566ca901554
|
e2e-full is green. |
Thx! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is a partial backport of commit 5c4ce8b.
What this PR does / why we need it:
The clusterctl upgrade test explicitly uses api version v1alpha3 to check for machine readiness, but this version is no longer served by CAPI 1.5. This means that the test now requires the 'before' version to be <1.5. While this doesn't impact the use of the clusterctl upgrade tests in CAPI itself, which explicitly tests upgrades from 1.3 and 1.4, but not 1.5, it does impact use by providers who are also running this test.
Which issue(s) this PR fixes:
Fixes #9411
/area testing