Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.5] 📖 Add a line about the format of key for clusterctl config #9518

Merged
merged 1 commit into from
Oct 3, 2023
Merged

[release-1.5] 📖 Add a line about the format of key for clusterctl config #9518

merged 1 commit into from
Oct 3, 2023

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #9513

/assign killianmuldoon

@musaprg @fabriziopandini
Add a line about the format of key for clusterctl config
5abdada 
Signed-off-by: Kotaro Inoue <inoue.kotaro@linecorp.com>

Update docs/book/src/clusterctl/configuration.md

Co-authored-by: killianmuldoon <47175296+killianmuldoon@users.noreply.github.com>

Update docs/book/src/clusterctl/configuration.md

Co-authored-by: Fabrizio Pandini <fabrizio.pandini@gmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Oct 3, 2023
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Oct 3, 2023
Merged
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 3, 2023
killianmuldoon
killianmuldoon reviewed Oct 3, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area documentation

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/needs-area PR is missing an area label labels Oct 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: eea31e1e5a2137983a32dc3fa759eb969d14d956

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 93daac9 into kubernetes-sigs:release-1.5 Oct 3, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@ykakarap ykakarap Awaiting requested review from ykakarap

Assignees

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
4 participants
@k8s-infra-cherrypick-robot @k8s-ci-robot @killianmuldoon @musaprg