-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix guestbook-go image #540 #542
base: master
Are you sure you want to change the base?
Conversation
The committers listed above are authorized under a signed CLA. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Shumakriss The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @Shumakriss! |
This may also fix #506 |
Can you sync with author of #544 and figure out how to combine the two PRs into one? |
/kind bug
The guestbook-go Dockerfile uses a relatively out of date version of golang, especially since it uses
go get
instead of modules andgo install
. This updates the base image and switches to a module-based build.Fixes #540
I am currently awaiting CNCF-CLA Approval but I have already signed the docs and permitted organization access to my forks of kubernetes/examples and kubernetes/contributor-playground.
The reason I started this was because I found an error in Minikube Dashboard about the guestbook pods. The error occurs when Docker attempts to pull
registry.k8s.io/guestbook:v3
which is using an outdated image format or manifest version. I am hoping that resolving the build issues will also result in an updated image in the public repo that will enable everyone to run guestbook-go pods on up-to-date environments but the image needed an update either way and this is something I can help with.Here's the error on Docker Pull that shows up in Minikube Dashboard: