Merge pull request #250 from Gentleelephant/release-2.5-fix-307-pr

fix bug
kubesphere · Mar 7, 2024 · 055bf5a · 055bf5a
2 parents 0b85773 + 5b75c59
commit 055bf5a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-v2.5.0-rc.2
+v2.5.0-rc.3
diff --git a/pkg/notify/notifier/email/email.go b/pkg/notify/notifier/email/email.go
@@ -19,6 +19,8 @@ import (
 	"strings"
 	"time"
 
+	"github.com/modern-go/reflect2"
+
 	"github.com/go-kit/kit/log"
 	"github.com/go-kit/kit/log/level"
 	"github.com/kubesphere/notification-manager/pkg/async"
@@ -203,7 +205,7 @@ func (n *Notifier) send(ctx context.Context, to, subject, body string) error {
 	if err != nil {
 		return err
 	}
-	if conn == nil {
+	if reflect2.IsNil(conn) {
 		return utils.Errorf("failed to connect to %s", addr)
 	}