Skip to content

Commit

Permalink
* metaconfig: add '-w' when running test cases.
Browse files Browse the repository at this point in the history
* test/test_metadata.rb: suppress warning: "shadowing outer local variable - i."
* ext/oci8/stmt.c: suppress warning: "warning: instance variable
    @max_array_size not initialized" at lib/oci8/oci8.rb:375.


git-svn-id: svn+ssh://rubyforge.org/var/svn/ruby-oci8/trunk/ruby-oci8@259 f081da96-e817-0410-9439-ba585a54bbf1
  • Loading branch information
kubo committed Apr 8, 2008
1 parent 1f22f09 commit 937e295
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 2 deletions.
6 changes: 6 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
2008-04-08 KUBO Takehiro <kubo@jiubao.org>
* metaconfig: add '-w' when running test cases.
* test/test_metadata.rb: suppress warning: "shadowing outer local variable - i."
* ext/oci8/stmt.c: suppress warning: "warning: instance variable
@max_array_size not initialized" at lib/oci8/oci8.rb:375.

2008-03-29 KUBO Takehiro <kubo@jiubao.org>
* ext/oci8/encoding.c, ext/oci8/extconf.rb, ext/oci8/oci8.h
ext/oci8/oci8lib.c: add a new file encoding.c.
Expand Down
1 change: 1 addition & 0 deletions ext/oci8/stmt.c
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ static VALUE oci8_stmt_initialize(int argc, VALUE *argv, VALUE self)
rb_ivar_set(stmt->base.self, id_at_column_metadata, rb_ary_new());
rb_ivar_set(stmt->base.self, id_at_names, Qnil);
rb_ivar_set(stmt->base.self, id_at_con, svc);
rb_ivar_set(stmt->base.self, id_at_max_array_size, Qnil);

if (argc > 1) {
rv = OCIStmtPrepare(stmt->base.hp.stmt, oci8_errhp, RSTRING_ORATEXT(sql), RSTRING_LEN(sql), OCI_NTV_SYNTAX, OCI_DEFAULT);
Expand Down
2 changes: 1 addition & 1 deletion metaconfig
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ ToplevelInstaller.module_eval {
old = Dir.pwd
@installer.mkdir_p "#{objdir_root}/test"
Dir.chdir "#{objdir_root}/test"
@installer.ruby("-I#{srcdir_root}/ext/oci8 -I#{srcdir_root}/lib -I#{srcdir_root}/support -I#{srcdir_root}/test #{srcdir_root}/test/test_all.rb")
@installer.ruby("-w -I#{srcdir_root}/ext/oci8 -I#{srcdir_root}/lib -I#{srcdir_root}/support -I#{srcdir_root}/test #{srcdir_root}/test/test_all.rb")
Dir.chdir old
end

Expand Down
2 changes: 1 addition & 1 deletion test/test_metadata.rb
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def test_metadata

drop_table('test_table')
sql = <<-EOS
CREATE TABLE test_table (#{i = 0; coldef.collect do |c| i += 1; "C#{i} " + c[1]; end.join(',')})
CREATE TABLE test_table (#{idx = 0; coldef.collect do |c| idx += 1; "C#{idx} " + c[1]; end.join(',')})
STORAGE (
INITIAL 100k
NEXT 100k
Expand Down

0 comments on commit 937e295

Please sign in to comment.