Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add node selector config #37

Merged
merged 2 commits into from
Sep 6, 2023
Merged

add node selector config #37

merged 2 commits into from
Sep 6, 2023

Conversation

lumjjb
Copy link
Contributor

@lumjjb lumjjb commented Aug 17, 2023

Add ability to add nodeSelector to config of most deployments

@sunnyyip
Copy link
Contributor

sunnyyip commented Aug 18, 2023 •
edited
Loading

@lumjjb I just cut a release to use the latest v0.1.2 version of guac which should fix the test. Can you rebase please?
@lumjjb ^^

@lumjjb
add node selector config
758c374 
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
@sunnyyip
Copy link
Contributor

sunnyyip commented Sep 6, 2023

@lumjjb can you please bump the chart version so your changes get released when merged?
i.e. set version to 0.2.3 at https://github.com/kusaridev/helm-charts/blob/main/charts/guac/Chart.yaml#L12

@lumjjb
update chart version
69dbae0 
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
@lumjjb
Copy link
Contributor Author

lumjjb commented Sep 6, 2023

done!

sunnyyip
sunnyyip approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@sunnyyip sunnyyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sunnyyip sunnyyip merged commit c9197db into kusaridev:main Sep 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunnyyip sunnyyip sunnyyip approved these changes

@trmiller trmiller Awaiting requested review from trmiller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lumjjb @sunnyyip