Guac v0.7.0 release #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sunny Yip <sunny@kusari.dev>
Signed-off-by: Sunny Yip <sunny@kusari.dev>
Signed-off-by: Sunny Yip <sunny@kusari.dev>
mlieberman85
reviewed
Jun 5, 2024
| @@ -17,6 +17,7 @@ imagePullSecrets: | |||
| ## @param guac.guacImage.workingDir Working Directory for GUAC | |||
| ## @param guac.common.env [string] common environment variables apply to all guac services | |||
| ## @param guac.common.tolerations [string] common tolerations apply to all guac services | |||
| ## @param guac.configMap.enabled Whether to create the guac-cm configMap | |||
There was a problem hiding this comment.
It's not clear what the guac-cm config map is here.
There was a problem hiding this comment.
The configmap contains the guac cli flag values.
The variable here allow one to not create the configmap and pass the flags individually into respective guac component or create their own config map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.