-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go Backend #13
Open
WillFantom
wants to merge
11
commits into
kutyla-philipp:master
Choose a base branch
from
WillFantom:go-backend
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Go Backend #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Fantom <w.fantom@lancs.ac.uk>
Signed-off-by: Will Fantom <w.fantom@lancs.ac.uk>
Signed-off-by: Will Fantom <w.fantom@lancs.ac.uk>
Signed-off-by: Will Fantom <w.fantom@lancs.ac.uk>
Signed-off-by: Will Fantom <w.fantom@lancs.ac.uk>
Signed-off-by: Will Fantom <w.fantom@lancs.ac.uk>
Signed-off-by: Will Fantom <w.fantom@lancs.ac.uk>
Signed-off-by: Will Fantom <w.fantom@lancs.ac.uk>
Signed-off-by: Will Fantom <w.fantom@lancs.ac.uk>
Signed-off-by: Will Fantom <w.fantom@lancs.ac.uk>
Signed-off-by: Will Fantom <w.fantom@lancs.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
So, the reason for switching to a GoLang backend is extensibility. This provides a better base for quickly adding features. To demonstrate this, I have added another page at the /admin endpoint that takes a password just as an example.
Furthermore, this can now run as a standalone binary, not requiring the use of an apache or Nginx server, making it far more simple to instantiate. But of course, the docker file provided also allow it to run easily atop the docker engine.
More features can be added to this, however, to ensure the pull request is focused, I have simply left the login page there as an example, thus, it does not provide any real benefit in its current format.
As a final benefit, the parsing of the JSON config is done statically, improving performance slightly.
More...
The scope of this is limited to the change of language, not new features. I do intend to push and merge other features that make use of the new backend program.