feat: add a link to open a cloned folder in a notification #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 28, 2024
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6 tasks
yomybaby
force-pushed
the
feature/model-store-clone
branch
from
79ba411
to
5500c3b
Compare
yomybaby
force-pushed
the
feature/cloned-folder-open-link
branch
from
c96ee79
to
baf0fab
Compare
yomybaby
force-pushed
the
feature/model-store-clone
branch
from
5500c3b
to
3ee25dd
Compare
yomybaby
force-pushed
the
feature/cloned-folder-open-link
branch
from
baf0fab
to
927f442
Compare
yomybaby
force-pushed
the
feature/model-store-clone
branch
from
3ee25dd
to
af360bc
Compare
yomybaby
force-pushed
the
feature/cloned-folder-open-link
branch
from
927f442
to
5dfbc43
Compare
Merge activity
|
ironAiken2
force-pushed
the
feature/model-store-clone
branch
from
af360bc
to
119f64e
Compare
yomybaby
force-pushed
the
feature/cloned-folder-open-link
branch
from
5dfbc43
to
a027af3
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 2.75% | 141/5122 |
| 🔴 | Branches | 2.95% | 101/3428 |
| 🔴 | Functions | 1.59% | 27/1699 |
| 🔴 | Lines | 2.63% | 132/5025 |
Test suite run success
51 tests passing in 5 suites.
Report generated by 🧪jest coverage report action from 1057197
yomybaby
force-pushed
the
feature/cloned-folder-open-link
branch
from
a027af3
to
9f03aad
Compare
### TL;DR Adds a feature that utilizes a link to open the folder explorer directly from a notification. ### What changed? - Updated `BAINotificationItem` component to use `notification.toText` property before falling back to other properties. - Adjusted `FolderExplorerOpener` to watch both `isDataViewReady` and `folderId` states. - Modified `ModelCloneModal` component to include new properties in mutation response and make use of them. - Extended `NotificationState` interface to include `toText` property. - Enhanced `BackendAIData` to handle folder explorers for different tabs. - Refactored folder explorer opening logic in `BackendAiStorageList` and introduced two new methods: `triggerOpenFilebrowserToReact` and `triggerCloseFilebrowserToReact`. ### How to test? 1. Clone folder in the Model store page. 2. Check if the clone result notification includes a link to open the folder explorer. 3. Ensure the link accurately directs to the correct folder based on different tabs. 4. Verify state updates and component behavior in `FolderExplorerOpener` and `ModelCloneModal`. ### Why make this change? To enhance user experience by providing direct access to folder explorers from notifications, streamlining the workflow and reducing the number of clicks needed to navigate to a folder. --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
force-pushed
the
feature/cloned-folder-open-link
branch
from
9f03aad
to
1057197
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds a feature that utilizes a link to open the folder explorer directly from a notification.
What changed?
BAINotificationItemcomponent to usenotification.toTextproperty before falling back to other properties.FolderExplorerOpenerto watch bothisDataViewReadyandfolderIdstates.ModelCloneModalcomponent to include new properties in mutation response and make use of them.NotificationStateinterface to includetoTextproperty.BackendAIDatato handle folder explorers for different tabs.BackendAiStorageListand introduced two new methods:triggerOpenFilebrowserToReactandtriggerCloseFilebrowserToReact.How to test?
FolderExplorerOpenerandModelCloneModal.Why make this change?
To enhance user experience by providing direct access to folder explorers from notifications, streamlining the workflow and reducing the number of clicks needed to navigate to a folder.
Checklist: (if applicable)