-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a link to open a cloned folder in a notification #2497
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
79ba411
to
5500c3b
Compare
c96ee79
to
baf0fab
Compare
5500c3b
to
3ee25dd
Compare
baf0fab
to
927f442
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works fine. LGTM!
3ee25dd
to
af360bc
Compare
927f442
to
5dfbc43
Compare
Merge activity
|
af360bc
to
119f64e
Compare
5dfbc43
to
a027af3
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 2.75% | 141/5122 |
🔴 | Branches | 2.95% | 101/3428 |
🔴 | Functions | 1.59% | 27/1699 |
🔴 | Lines | 2.63% | 132/5025 |
Test suite run success
51 tests passing in 5 suites.
Report generated by 🧪jest coverage report action from 1057197
a027af3
to
9f03aad
Compare
### TL;DR Adds a feature that utilizes a link to open the folder explorer directly from a notification. ### What changed? - Updated `BAINotificationItem` component to use `notification.toText` property before falling back to other properties. - Adjusted `FolderExplorerOpener` to watch both `isDataViewReady` and `folderId` states. - Modified `ModelCloneModal` component to include new properties in mutation response and make use of them. - Extended `NotificationState` interface to include `toText` property. - Enhanced `BackendAIData` to handle folder explorers for different tabs. - Refactored folder explorer opening logic in `BackendAiStorageList` and introduced two new methods: `triggerOpenFilebrowserToReact` and `triggerCloseFilebrowserToReact`. ### How to test? 1. Clone folder in the Model store page. 2. Check if the clone result notification includes a link to open the folder explorer. 3. Ensure the link accurately directs to the correct folder based on different tabs. 4. Verify state updates and component behavior in `FolderExplorerOpener` and `ModelCloneModal`. ### Why make this change? To enhance user experience by providing direct access to folder explorers from notifications, streamlining the workflow and reducing the number of clicks needed to navigate to a folder. --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
9f03aad
to
1057197
Compare
TL;DR
Adds a feature that utilizes a link to open the folder explorer directly from a notification.
What changed?
BAINotificationItem
component to usenotification.toText
property before falling back to other properties.FolderExplorerOpener
to watch bothisDataViewReady
andfolderId
states.ModelCloneModal
component to include new properties in mutation response and make use of them.NotificationState
interface to includetoText
property.BackendAIData
to handle folder explorers for different tabs.BackendAiStorageList
and introduced two new methods:triggerOpenFilebrowserToReact
andtriggerCloseFilebrowserToReact
.How to test?
FolderExplorerOpener
andModelCloneModal
.Why make this change?
To enhance user experience by providing direct access to folder explorers from notifications, streamlining the workflow and reducing the number of clicks needed to navigate to a folder.
Checklist: (if applicable)