fix: 0 desired routing count in endpoint edit page #2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
yomybaby
force-pushed
the
fix/routing-count-in-endpoint-editor
branch
2 times, most recently
from
58f92c0
to
0a3e496
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.09% | 348/6833 |
| 🔴 | Branches | 4.65% | 218/4692 |
| 🔴 | Functions | 2.97% | 67/2256 |
| 🔴 | Lines | 4.99% | 333/6674 |
Test suite run success
93 tests passing in 12 suites.
Report generated by 🧪jest coverage report action from 3e45cde
Merge activity
|
**Changes:** This PR modifies the `ServiceLauncherPageContent` component to use the nullish coalescing operator (`??`) instead of the logical OR operator (`||`) when setting the `desiredRoutingCount` value. This ensures that a value of `0` for `endpoint?.desired_session_count` is respected rather than defaulting to `1`. **Rationale:** The previous implementation using `||` would treat `0` as a falsy value, causing it to default to `1`. By using `??`, we now correctly handle cases where `desired_session_count` is explicitly set to `0`, while still defaulting to `1` when the value is `null` or `undefined`. **Impact:** This change allows users to set a `desired_session_count` of `0` for endpoints, which may be necessary for certain service configurations or management scenarios.
yomybaby
force-pushed
the
fix/routing-count-in-endpoint-editor
branch
from
0a3e496
to
3e45cde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR modifies the
ServiceLauncherPageContentcomponent to use the nullish coalescing operator (??) instead of the logical OR operator (||) when setting thedesiredRoutingCountvalue. This ensures that a value of0forendpoint?.desired_session_countis respected rather than defaulting to1.Rationale:
The previous implementation using
||would treat0as a falsy value, causing it to default to1. By using??, we now correctly handle cases wheredesired_session_countis explicitly set to0, while still defaulting to1when the value isnullorundefined.Impact:
This change allows users to set a
desired_session_countof0for endpoints, which may be necessary for certain service configurations or management scenarios.