-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 0 desired routing count in endpoint edit page #2768
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
58f92c0
to
0a3e496
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 5.09% | 348/6833 |
🔴 | Branches | 4.65% | 218/4692 |
🔴 | Functions | 2.97% | 67/2256 |
🔴 | Lines | 4.99% | 333/6674 |
Test suite run success
93 tests passing in 12 suites.
Report generated by 🧪jest coverage report action from 3e45cde
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge activity
|
**Changes:** This PR modifies the `ServiceLauncherPageContent` component to use the nullish coalescing operator (`??`) instead of the logical OR operator (`||`) when setting the `desiredRoutingCount` value. This ensures that a value of `0` for `endpoint?.desired_session_count` is respected rather than defaulting to `1`. **Rationale:** The previous implementation using `||` would treat `0` as a falsy value, causing it to default to `1`. By using `??`, we now correctly handle cases where `desired_session_count` is explicitly set to `0`, while still defaulting to `1` when the value is `null` or `undefined`. **Impact:** This change allows users to set a `desired_session_count` of `0` for endpoints, which may be necessary for certain service configurations or management scenarios.
0a3e496
to
3e45cde
Compare
Changes:
This PR modifies the
ServiceLauncherPageContent
component to use the nullish coalescing operator (??
) instead of the logical OR operator (||
) when setting thedesiredRoutingCount
value. This ensures that a value of0
forendpoint?.desired_session_count
is respected rather than defaulting to1
.Rationale:
The previous implementation using
||
would treat0
as a falsy value, causing it to default to1
. By using??
, we now correctly handle cases wheredesired_session_count
is explicitly set to0
, while still defaulting to1
when the value isnull
orundefined
.Impact:
This change allows users to set a
desired_session_count
of0
for endpoints, which may be necessary for certain service configurations or management scenarios.