fix: handle current resource group using initial values in launchers #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.09% (-0% 🔻) |
348/6837 |
| 🔴 | Branches | 4.64% (-0% 🔻) |
218/4694 |
| 🔴 | Functions | 2.97% | 67/2256 |
| 🔴 | Lines | 4.99% (-0% 🔻) |
333/6678 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / ResourceGroupSelectForCurrentProject.tsx |
0% (-6.25% 🔻) |
0% | 0% | 0% (-6.25% 🔻) |
Test suite run success
93 tests passing in 12 suites.
Report generated by 🧪jest coverage report action from 5a5bcfe
Merge activity
|
…2774) This PR control the resource group value of the launcher using initial values, and update the global current resource group through the launcher when creating, so that the resource group of the resource monitor becomes the resource group just used. resolve #2770 - Replacing ResourceGroupSelectForCurrentProject with ResourceGroupSelect component - Adding resource group state management to maintain selection consistency - Setting initial form values with the current global resource group - Updating the global resource group state when creating new sessions or services.
yomybaby
force-pushed
the
fix/current-resource-group-in-launchers
branch
from
803b29d
to
5a5bcfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR control the resource group value of the launcher using initial values, and update the global current resource group through the launcher when creating, so that the resource group of the resource monitor becomes the resource group just used.
resolve #2770