-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle current resource group using initial values in launchers #2774
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 5.09% (-0% 🔻) |
348/6837 |
🔴 | Branches | 4.64% (-0% 🔻) |
218/4694 |
🔴 | Functions | 2.97% | 67/2256 |
🔴 | Lines | 4.99% (-0% 🔻) |
333/6678 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🔴 | ... / ResourceGroupSelectForCurrentProject.tsx |
0% (-6.25% 🔻) |
0% | 0% | 0% (-6.25% 🔻) |
Test suite run success
93 tests passing in 12 suites.
Report generated by 🧪jest coverage report action from 5a5bcfe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge activity
|
…2774) This PR control the resource group value of the launcher using initial values, and update the global current resource group through the launcher when creating, so that the resource group of the resource monitor becomes the resource group just used. resolve #2770 - Replacing ResourceGroupSelectForCurrentProject with ResourceGroupSelect component - Adding resource group state management to maintain selection consistency - Setting initial form values with the current global resource group - Updating the global resource group state when creating new sessions or services.
803b29d
to
5a5bcfe
Compare
This PR control the resource group value of the launcher using initial values, and update the global current resource group through the launcher when creating, so that the resource group of the resource monitor becomes the resource group just used.
resolve #2770