Skip to content

Commit

Permalink
fix: Wrong parameter when call 'recalc_agent_resource_occupancy()' (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
fregataa authored Oct 25, 2024
1 parent 74f3107 commit 11d8795
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions changes/2982.fix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a wrong parameter when call 'recalc_agent_resource_occupancy()'
10 changes: 5 additions & 5 deletions src/ai/backend/manager/scheduler/dispatcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -1530,9 +1530,9 @@ async def start_session(
# SCHEDULED and retry within some limit using status_data.

async def _mark_session_cancelled() -> None:
async with self.db.begin() as db_conn:
async with self.db.begin_session() as db_session:
affected_agents = set(k.agent for k in session.kernels)
await _rollback_predicate_mutations(db_conn, sched_ctx, session)
await _rollback_predicate_mutations(db_session, sched_ctx, session)
now = datetime.now(tzutc())
update_query = (
sa.update(KernelRow)
Expand All @@ -1552,7 +1552,7 @@ async def _mark_session_cancelled() -> None:
)
.where(KernelRow.session_id == session.id)
)
await SASession(db_conn).execute(update_query)
await db_session.execute(update_query)
update_sess_query = (
sa.update(SessionRow)
.values(
Expand All @@ -1571,9 +1571,9 @@ async def _mark_session_cancelled() -> None:
)
.where(SessionRow.id == session.id)
)
await SASession(db_conn).execute(update_sess_query)
await db_session.execute(update_sess_query)
for agent_id in affected_agents:
await recalc_agent_resource_occupancy(db_conn, agent_id)
await recalc_agent_resource_occupancy(db_session, agent_id)

log.debug(log_fmt + "cleanup-start-failure: begin", *log_args)
try:
Expand Down

0 comments on commit 11d8795

Please sign in to comment.