fix: Silence falsy Redis timeout warnings with blocking commands (#2632)

lablup · Aug 3, 2024 · 2b41d6d · 2b41d6d
1 parent 970535a
commit 2b41d6d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/changes/2632.fix.md b/changes/2632.fix.md
@@ -0,0 +1 @@
+Silence falsy Redis timeout warnings when retrying blocking commands if the timeout does not exceed the expected command timeout
diff --git a/src/ai/backend/common/redis_helper.py b/src/ai/backend/common/redis_helper.py
@@ -267,6 +267,7 @@ def show_retry_warning(e: Exception, warn_on_first_attempt: bool = True) -> None
                 now = time.perf_counter()
                 if now - first_trial >= command_timeout + 1.0:
                     show_retry_warning(e)
+                first_trial = now
             continue
         except redis.exceptions.ResponseError as e:
             if "NOREPLICAS" in e.args[0]: