Skip to content

Commit

Permalink
fix: Disallow None id encoding in AsyncNode.to_global_id() (#2898)
Browse files Browse the repository at this point in the history
Backported-from: main
Backported-to: 24.03
Backported-of: 2898
  • Loading branch information
jopemachine committed Oct 24, 2024
1 parent 7dab319 commit 9bac071
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions changes/2898.fix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Disallow `None` id encoding in `AsyncNode.to_global_id()`.
6 changes: 4 additions & 2 deletions src/ai/backend/manager/models/gql_relay.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,10 @@ async def node_resolver(cls, only_type, root, info, id):
return await cls.get_node_from_global_id(info, id, only_type=only_type)

@staticmethod
def to_global_id(type_, id) -> str:
return base64(f"{type_}:{id}")
def to_global_id(type_, id_) -> str:
if id_ is None:
raise Exception("Encoding None value as Global ID is not allowed.")
return base64(f"{type_}:{id_}")

@classmethod
def resolve_global_id(cls, info, global_id: str) -> tuple[str, str]:
Expand Down

0 comments on commit 9bac071

Please sign in to comment.