-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add the manager's RPC client certificate entry to the guide #2052
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments.
I fixed typos for the latest version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified some explanation to make document better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made some changes in description, such as key pair to kaypair, etc. Was only able to change the newly added part.
To add the manager's RPC client certificate entry to the guide. Following the merged PR #887 , manager.toml config file's rpc-auth-manager-keypair filed is always required, even when no agents require authentication and encryption. As a result, add the manager's RPC client certificate entry to the guide. fix #2044
add: news fragment
fix typos for the latest version
doc: change absolute path to relative path on manager.toml example On the example of manager.toml, some key's value use absolute path. As a result, removed hardcoded references(absolute path) and modified relative path
efa8541
to
93d16a7
Compare
…db container - Also split the lines by sentence boundaries. (FYI: .editorconfig already says .md/.rst files have no line length limits!)
To add the manager's RPC client certificate entry to the guide.
Following the merged PR #887 , manager.toml config file's rpc-auth-manager-keypair filed is always required, even when no agents require authentication and encryption.
As a result, add the manager's RPC client certificate entry to the guide.
fix #2044
Checklist: (if applicable)
docs
directory📚 Documentation preview 📚: https://sorna--2052.org.readthedocs.build/en/2052/
📚 Documentation preview 📚: https://sorna-ko--2052.org.readthedocs.build/ko/2052/