Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Utilization idle checker calculates resource name to avoid hard code #2702

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Aug 12, 2024

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)

Copy link
Member Author

fregataa commented Aug 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fregataa and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added comp:manager Related to Manager component comp:agent Related to Agent component size:L 100~500 LoC labels Aug 12, 2024
@fregataa fregataa force-pushed the topic/08-12-refactor_skip_util_idle_check_for_unallocated_resource branch 2 times, most recently from 47ddeff to f8f662d Compare August 12, 2024 08:31
@fregataa fregataa changed the base branch from main to topic/08-12-feat_add_pydantic_based_config_model August 12, 2024 08:31
@fregataa fregataa force-pushed the topic/08-12-refactor_skip_util_idle_check_for_unallocated_resource branch from f8f662d to 9167855 Compare August 12, 2024 08:56
@fregataa fregataa force-pushed the topic/08-12-feat_add_pydantic_based_config_model branch from ef00c17 to 0b50036 Compare August 12, 2024 12:47
@fregataa fregataa force-pushed the topic/08-12-refactor_skip_util_idle_check_for_unallocated_resource branch from 9167855 to 08ff6d2 Compare August 12, 2024 12:47
@fregataa fregataa force-pushed the topic/08-12-feat_add_pydantic_based_config_model branch from 0b50036 to b44daa9 Compare August 14, 2024 09:33
@fregataa fregataa force-pushed the topic/08-12-refactor_skip_util_idle_check_for_unallocated_resource branch from 08ff6d2 to b774cc9 Compare August 14, 2024 09:33
@fregataa fregataa force-pushed the topic/08-12-feat_add_pydantic_based_config_model branch from b44daa9 to 0b2b8eb Compare August 20, 2024 09:49
@fregataa fregataa force-pushed the topic/08-12-refactor_skip_util_idle_check_for_unallocated_resource branch from b774cc9 to ee70f7c Compare August 20, 2024 09:49
@fregataa fregataa force-pushed the topic/08-12-feat_add_pydantic_based_config_model branch from 0b2b8eb to 1cc771d Compare September 30, 2024 08:12
@fregataa fregataa force-pushed the topic/08-12-refactor_skip_util_idle_check_for_unallocated_resource branch 2 times, most recently from 12b7fe4 to 7118cb3 Compare October 2, 2024 03:06
@fregataa fregataa changed the base branch from topic/08-12-feat_add_pydantic_based_config_model to main October 2, 2024 03:06
@fregataa fregataa added this to the 24.09 milestone Oct 2, 2024
@fregataa fregataa force-pushed the topic/08-12-refactor_skip_util_idle_check_for_unallocated_resource branch from 1afbf94 to 2c47ca4 Compare October 7, 2024 07:44
@fregataa fregataa force-pushed the topic/08-12-refactor_skip_util_idle_check_for_unallocated_resource branch from d06b309 to 88b02c9 Compare October 21, 2024 12:43
@fregataa fregataa marked this pull request as ready for review October 21, 2024 12:45
@fregataa fregataa added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 648cfeb Oct 21, 2024
18 checks passed
@fregataa fregataa deleted the topic/08-12-refactor_skip_util_idle_check_for_unallocated_resource branch October 21, 2024 13:27
lablup-octodog pushed a commit that referenced this pull request Oct 21, 2024
…hard code (#2702)

Backported-from: main (24.12)
Backported-to: 24.09
Backport-of: 2702
@fregataa fregataa added the skip:changelog Make the action workflow to skip towncrier check label Oct 21, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 21, 2024
…hard code (#2702) (#2929)

Co-authored-by: Sanghun Lee <sanghun@lablup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:agent Related to Agent component comp:manager Related to Manager component size:L 100~500 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant