Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use a valid value for the id field in the GQL schema query resolver for ContainerRegistry. #2908

Merged

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Oct 14, 2024

follows #1917

By using id instead of registry_name, I have resolved the issue where the id values returned in the ContainerRegistry API were all the same.
image.png

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @agatha197 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added comp:manager Related to Manager component size:XS ~10 LoC labels Oct 14, 2024
@agatha197 agatha197 force-pushed the refactor/_id-field-assignment-in-ContainerRegistryNode branch from d4cfb7c to eb56e54 Compare October 14, 2024 07:07
@agatha197 agatha197 changed the title refactor: id field assignment in ContainerRegistryNode fix: Use a valid value for the id field in the GQL schema query resolver for ContainerRegistry. Oct 14, 2024
@agatha197 agatha197 force-pushed the refactor/_id-field-assignment-in-ContainerRegistryNode branch from eb56e54 to 13d762e Compare October 14, 2024 07:15
@agatha197 agatha197 modified the milestones: 23.09, 24.09 Oct 14, 2024
@fregataa fregataa added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit 0329505 Oct 14, 2024
25 of 26 checks passed
@fregataa fregataa deleted the refactor/_id-field-assignment-in-ContainerRegistryNode branch October 14, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants