Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Calculate correct expiration time of VAST auth token #2911

Merged
merged 5 commits into from
Oct 15, 2024
Merged

fix: Calculate correct expiration time of VAST auth token #2911

merged 5 commits into from
Oct 15, 2024

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Oct 15, 2024 •
edited
Loading

  1. Fix calculation of expiration datetime of VAST auth token by comparing current time with token's exp time.
  2. Change config name from use_auth_token to force_login
  3. Replace dateutil.tz.tzutc() with datetime.timezone.utc

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@fregataa fregataa added this to the 24.03 milestone Oct 15, 2024
@fregataa fregataa requested a review from adrysn October 15, 2024 05:07
@fregataa fregataa self-assigned this Oct 15, 2024
@github-actions github-actions bot added comp:storage-proxy Related to Storage proxy component size:M 30~100 LoC labels Oct 15, 2024
@fregataa fregataa added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit dcfd1f9 Oct 15, 2024
20 checks passed
@fregataa fregataa deleted the fix/wrong-calc-of-vast-auth-token branch October 15, 2024 06:17
lablup-octodog pushed a commit that referenced this pull request Oct 15, 2024
@fregataa
fix: Calculate correct expiration time of VAST auth token (#2911)
888aa16 
Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2911
@lablup-octodog lablup-octodog mentioned this pull request Oct 15, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 15, 2024
@lablup-octodog @fregataa
fix: Calculate correct expiration time of VAST auth token (#2911) (#2912
9d188cc 
)

Co-authored-by: Sanghun Lee <sanghun@lablup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrysn adrysn Awaiting requested review from adrysn

Assignees

@fregataa fregataa

Labels
comp:storage-proxy Related to Storage proxy component size:M 30~100 LoC
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.
1 participant
@fregataa