fix: update Dellemc OneFS backend #2918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
github-actions
bot
added
comp:storage-proxy
Base automatically changed from
topic/10-17-chore_fix_typo_in_storage_backend_codes
to
main
October 17, 2024 07:46
fregataa
force-pushed
the
topic/10-17-fix_update_dellemc_onefs_backend
branch
from
24d19f8
to
606dabf
Compare
fregataa
force-pushed
the
topic/10-17-fix_update_dellemc_onefs_backend
branch
from
a0fd320
to
7850c68
Compare
kyujin-cho
requested changes
Oct 21, 2024
| @@ -37,19 +36,14 @@ def __init__( | |||
| password: str, | |||
| *, | |||
| api_version: str = "12", | |||
| system_name: str = "nfs", | |||
| system_name: Optional[str] = "nfs", | |||
There was a problem hiding this comment.
What is the role of this parameter? How/where do we derive it from cluster configuration?
There was a problem hiding this comment.
I checked that the parameter is used when this client queries workload stats of OneFS. I changed this parameter as nullable since the workload stat API does not require system_name parameter. I left the default value as the same to reduce side effects.
Plus, only through the OneFS API can we know which system names are available.
fregataa
force-pushed
the
topic/10-17-fix_update_dellemc_onefs_backend
branch
from
d21a974
to
6ce917f
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes
AbstractVolume.initcoroutine method, letDellEMCOneFSVolumecall super init methodChecklist: (if applicable)