-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update Dellemc OneFS backend #2918
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
24d19f8
to
606dabf
Compare
a0fd320
to
7850c68
Compare
@@ -37,19 +36,14 @@ def __init__( | |||
password: str, | |||
*, | |||
api_version: str = "12", | |||
system_name: str = "nfs", | |||
system_name: Optional[str] = "nfs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the role of this parameter? How/where do we derive it from cluster configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked that the parameter is used when this client queries workload stats of OneFS. I changed this parameter as nullable since the workload stat API does not require system_name
parameter. I left the default value as the same to reduce side effects.
Plus, only through the OneFS API can we know which system names are available.
d21a974
to
6ce917f
Compare
Main changes
AbstractVolume.init
coroutine method, letDellEMCOneFSVolume
call super init methodChecklist: (if applicable)