Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update pants build command #2945

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

HyeockJinKim
Copy link

@HyeockJinKim HyeockJinKim commented Oct 23, 2024

The path required for the LOCKSET setting has changed when using towncrier, reflect this in the documentation.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

📚 Documentation preview 📚: https://sorna--2945.org.readthedocs.build/en/2945/


📚 Documentation preview 📚: https://sorna-ko--2945.org.readthedocs.build/ko/2945/

@HyeockJinKim HyeockJinKim self-assigned this Oct 23, 2024
@github-actions github-actions bot added area:docs Documentations size:XS ~10 LoC labels Oct 23, 2024
docs/dev/daily-workflows.rst Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may omit the news fragment for this kind of "simple" documentation updates, by applying the skip:changelog label.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't realize that. I'll leave out the segment and add a label.

HyeockJinKim and others added 2 commits October 25, 2024 18:16
Co-authored-by: Joongi Kim <joongi@lablup.com>
@HyeockJinKim HyeockJinKim added the skip:changelog Make the action workflow to skip towncrier check label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations size:XS ~10 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants