Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set readonly flag to false when begin new generic txn #2946

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix: Set readonly flag to false when begin new generic txn #2946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84beb10
fix: Set readonly flag to false when begin new generic txn
fregataa Oct 23, 2024
e653788
Add news fragment
fregataa Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/2946.fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Set the `postgres_readonly` flag to `false` when begin generic sessions
5 changes: 4 additions & 1 deletion src/ai/backend/manager/models/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,10 @@ async def _begin(self, connection: SAConnection) -> AsyncIterator[SAConnection]:
"""
Begin generic transaction within the given connection.
"""
async with connection.begin():
conn_with_exec_opts = await connection.execution_options(
postgresql_readonly=False,
)
async with conn_with_exec_opts.begin():
self._generic_txn_count += 1
self._check_generic_txn_cnt()
try:
Expand Down