Rename Docker build images #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naming is controlled by the `makefile`, and would require rebuilding images if it were to change. As such, it should be included in the set of changed files that will trigger a rebuild for any given platform.
We don't want to confuse people by suggesting the images contain a fully built NAS2D library. Rather, they are the build environments needed to build NAS2D, as used by the CI workflows.
The Docker build commands and imported into the main `makefile`, so can be run from there. There is no need to explicitly specify the subfolder. This simplifies renaming the subfolder.
This is perhaps a better description of the folder contents. For apps, we might expect a "docker" folder to be for building images that contain the app. What we are doing here is building images that can be used to build the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change naming scheme to more clearly indicate these are build environments (as opposed to containing a fully built library). This impacts the image name, the folder name, the workflow name, and associated variables.
Change the default Docker registry from DockerHub to GitHub.
Allow changes to the
makefileto cause a rebuild of all environments. The makefile is responsible for the naming, and any changes to the naming will require rebuilding images for all environments.Part of: