Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vcpkg GitHub Actions Cache support #1177

Merged
merged 7 commits into from
Nov 27, 2024
Merged

Conversation

DanRStevens
Copy link
Collaborator

Use vcpkg GitHub Actions Cache support to replace the Nuget option for binary package caching.

Rename the overall package collection cache key for better clarity.

It appears there is still a significant speed benefit to keeping a cache of the overall collection, and not simply relying on the caches of individual binary packages. Though that was true before, when we kept an overall package collection cache, and used Nuget to cache individual binary packages.

Related:

Replace the Nuget package caching for binary packages with the GitHub Actions Cache support.
This means we rely on the caches of each individual binary package, rather than the entire collection of all of them.
This reverts commit b436350.

It appears there is a significant speed advantage to caching all packages as a whole.
This makes the `key` more consistent with the `buildCachei-` prefixed `key`. This should make it easier to see the purpose of the cache entry on the caches page:

https://github.com/lairworks/nas2d-core/actions/caches
@DanRStevens DanRStevens merged commit ae0b1f4 into main Nov 27, 2024
8 checks passed
@DanRStevens DanRStevens deleted the vcpkgGitHubActionsCache branch November 27, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant