Skip to content

Commit

Permalink
Add cairo_pie_output flag to cairo1-run (#1581)
Browse files Browse the repository at this point in the history
* First draft

* Add special serialization for ecdsa builtin additional data

* Start comparison script

* Add compare_all_no_proof target

* Update file permissions

* Fix makefile

* Add special serialization for pedersen builtin additional data

* Fix prev commit

* Serialize ecdsa additional data as sequence

* Expand comparison script

* Skip bugged case + Reduce amount of prints in comparison script

* Improve skip

* Add comparison to CI

* Fix

* Fix pie memory serialization

* Fix constant value

* Save temp changes

* Revert "Fix constant value"

This reverts commit 08e037e.

* Use to_bytes instead of serialize impl + simplify scripts

* Cleanup

* Fix test

* Clean interface + remove unwraps

* Fixes

* clippy

* Move arg validation to a separate func

* Move mutually exclusive argument validation to clap

* rename var

* Add Chaneglog entry

* Make zip dep optional

* Fix wasm imports

* Add file extension

* Add file extension

* Remove unwrap + improve coverage

* Add cairo_pie_output + Improve argument handling

* Add cairo_pie_output flag to tests

* Set builtins stop sptrs

* Add Chaneglog entry

* quick fix

* Clean solution

* Apply fix to cairo1-run cli

* Update README

* Update README

* Fix
  • Loading branch information
fmoletta authored Jan 22, 2024
1 parent 2f715c4 commit 826e72c
Show file tree
Hide file tree
Showing 3 changed files with 45 additions and 56 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

#### Upcoming Changes

* feat: Add `cairo_pie_output` flag to `cairo1-run` [#1581] (https://github.com/lambdaclass/cairo-vm/pull/1581)

* feat: Add `cairo_pie_output` flag to `cairo_vm_cli` [#1578] (https://github.com/lambdaclass/cairo-vm/pull/1578)
* Fix serialization of CairoPie to be fully compatible with the python version
* Add `CairoPie::write_zip_file`
Expand Down
2 changes: 2 additions & 0 deletions cairo1-run/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,5 @@ The cairo1-run cli supports the following optional arguments:
* `--air_public_input <AIR_PUBLIC_INPUT>`: Receives the name of a file and outputs the AIR public inputs into it. Can only be used if proof_mode is also enabled.

* `--air_private_input <AIR_PRIVATE_INPUT>`: Receives the name of a file and outputs the AIR private inputs into it. Can only be used if proof_mode, trace_file & memory_file are also enabled.

* `--cairo_pie_output <CAIRO_PIE_OUTPUT>`: Receives the name of a file and outputs the Cairo PIE into it. Can only be used if proof_mode, is not enabled.
Loading

0 comments on commit 826e72c

Please sign in to comment.