-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate VM documentation #1866
Open
JulianGCalderon
wants to merge
18
commits into
main
Choose a base branch
from
docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1866 +/- ##
=======================================
Coverage 96.33% 96.33%
=======================================
Files 102 102
Lines 40751 40751
=======================================
Hits 39259 39259
Misses 1492 1492 ☔ View full report in Codecov by Sentry. |
Benchmark Results for unmodified programs 🚀
|
JulianGCalderon
added
the
documentation
Improvements or additions to documentation
label
Nov 4, 2024
JulianGCalderon
changed the title
Consolidate documentation
Consolidate VM documentation
Dec 19, 2024
JulianGCalderon
requested review from
igaray,
Oppen,
fmoletta,
juanbono,
pefontana and
gabrielbosio
as code owners
December 19, 2024 17:05
JulianGCalderon
force-pushed
the
docs
branch
2 times, most recently
from
December 19, 2024 17:59
8b8b975
to
05ada2c
Compare
JulianGCalderon
force-pushed
the
docs
branch
3 times, most recently
from
December 19, 2024 21:14
83febf9
to
095596d
Compare
JulianGCalderon
force-pushed
the
docs
branch
from
December 19, 2024 21:14
095596d
to
f112a3e
Compare
fmoletta
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate documentation
This PR consolidates documentation from other repositories into the
docs
directory.Description
How does the VM work?
section, explaining core VM concepts. It was taken from https://github.com/lambdaclass/cairo-vm_in_go, but modified to be more generic.Next Steps