Add to_bits_be for FieldElement<Stark252PrimeField>
#866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bits operations in field elements is a bad idea. In the base type it's ok, if you want to use it you should use the raw data of the base type or call the representative. Calling the representative all the time means a heavy penalty to the operation cost, so it's not a good idea to use it |
|
I see now that we have the to bits_le, we should probably remove both in the future, in the meanwhile we can add it |
|
We will be removing the functionality of to_bits_le, so I am closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
to_bits_beforFieldElement<Stark252PrimeField>Description
Following
to_bits_le, an implementation ofto_bits_beforFieldElement<Stark252PrimeField>is added. A unit test is also integrated to validate the correct implementation of the two methods.Type of change
Please delete options that are not relevant.
Checklist