feat: Allow merkle trees of 1 node (its root) #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uri-99
changed the title
diegokingston
approved these changes
Sep 26, 2024
Oppen
reviewed
Sep 26, 2024
Co-authored-by: Mario Rugiero <mrugiero@gmail.com>
ColoCarletti
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow merkle trees of 1 node
Description
This PR removes the constraint from
is_power_of_two()that said 1 is not a power of 2.In turn, this allows Merkle Trees of size 1 to be built, without padding them to 2 nodes. Size 1 Merkle Trees are then only 1 node, which is equal to its root.
Type of change
Checklist