Add Missing Components for BLS12-377 Curve #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// (a0 + a1 * t) * (b0 + b1 * t) = a0 * b0 + a1 * b1 * Self::residue() + (a0 * b1 + a1 * b0) * t | ||
| /// where `t.pow(2)` equals `Q::residue()`. | ||
| fn mul(a: &Self::BaseType, b: &Self::BaseType) -> Self::BaseType { | ||
| let q = -FieldElement::from(5); // This is where u^2 = -5 is applied |
There was a problem hiding this comment.
Have this as a constant, since it is the non-residue
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #922 +/- ##
==========================================
+ Coverage 70.95% 70.96% +0.01%
==========================================
Files 143 144 +1
Lines 31284 31669 +385
==========================================
+ Hits 22197 22474 +277
- Misses 9087 9195 +108 ☔ View full report in Codecov by Sentry. |
diegokingston
approved these changes
Oct 1, 2024
| pub struct BLS12377Residue; | ||
| impl HasQuadraticNonResidue<BLS12377PrimeField> for BLS12377Residue { | ||
| fn residue() -> FieldElement<BLS12377PrimeField> { | ||
| -FieldElement::from(5) |
There was a problem hiding this comment.
This should be the constant
ColoCarletti
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Missing Components for BLS12-377 Curve
Description
This PR adds the missing components of the curve, such as the twist and field extension implementations