core: Allow nested prompt templates #28024
Open
+96
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
the
size:L
dmenini
commented
Nov 11, 2024
| } | ||
|
|
||
| # Filter template variables based on | ||
| # partial_variables and nested_partial_vars | ||
| values["input_variables"] = [ |
There was a problem hiding this comment.
This is the only point I found a bit counterintuitive. Imo if the user passes input_variables to the PromptTemplate we should not overwrite them with values from the template. This complicates the logic as I had to make sure that the nested partial variables are correctly excluded, to not break backward compatibility.
dmenini
force-pushed
the
core/inject-partial-to-partial-variables
branch
from
ee87817 to
6905b5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to use nested prompt templates.
partialnow checks if the partial variable is aPromptTemplateand it will propagate partial variables to itformatwill first format the nested prompts and the root promptIn my application, we allow users to write part of prompts (i.e. specific instructions), which may contain input variables. After this change, it will be possible for us to instantiate those instructions as
PromptTemplate, and pass them to the main prompts as partial variables.N.B. I know that there is PipelinePromptTemplate that does something similar, but it doesn't support partial prompts as of now, and imo it should not be needed if the
PromptTemplateitself can handle nested prompts.Thanks for your feedback!
@hwchase17 @baskaryan