Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deeplake v4 support #28104

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

azat-manukyan
Copy link

  • PR title: "community: Added support for Deeplake v4"

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 0:33am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. community Related to langchain-community Ɑ: vector store Related to vector store module labels Nov 14, 2024
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs support for a larger review. if you're interested in workign with deeplake to publish a dedicated integration package - feel free to follow this guide as well!

https://python.langchain.com/docs/contributing/how_to/integrations/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's revert these changes. you're welcome to add a warning if the version doesn't start with 3 on init if this doesn't work with v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community size:L This PR changes 100-499 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
Status: Needs support
Development

Successfully merging this pull request may close these issues.

2 participants