Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community: update VDMS vectorstore with latest VDMS release #28443

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

community: update VDMS vectorstore with latest VDMS release #28443

wants to merge 26 commits into from
+2,431 −2,366

Conversation

cwlacewe
Copy link
Contributor

@cwlacewe cwlacewe commented Dec 2, 2024

Description:

  • Update to use changes made to VDMS v2.10.0 and include some optimizations
  • Use test suite for testing as suggested in PR #23729.
  • Reran VDMS related notebooks using changes

Issue: N/A

Dependencies: N/A

cwlacewe added 22 commits October 17, 2024 12:24
@cwlacewe
Update vdms test suite, revamp vdms vectorstore, rerun notebooks
1842ad3
@cwlacewe
Update property flag name
85442dc
@cwlacewe
Merge branch 'master' into test_update
e75a96d
@cwlacewe
revert change of distance metric name
d4cacfc
@cwlacewe
Fix arg within max_marginal_relevance_search_by_vector
3727c03
@cwlacewe
Fix property generation (batch vs 1)
04e431d
@cwlacewe
Update batch_size
18a52a9
@cwlacewe
Minor updates to other vdms related files
f66fd09
@cwlacewe
Merge branch 'master' into test_update
80bc98e
@cwlacewe
Code cleanup using kwargs
71467f1
@cwlacewe
Merge branch 'master' into test_update
1a156d8
@cwlacewe
format fix
7a7a576
@cwlacewe
Update VDMS notebook and minor update to vectorstore
7f650e8
@cwlacewe
Reran cookbooks with updates
f6782ec
@cwlacewe
Remove logger as an input to vectorstore
f3c4e24
@cwlacewe
Fix k_candidates
4f97f12
@cwlacewe
clean annotations; rerun notebooks
59ac831
@cwlacewe
Merge branch 'master' into test_update
e354178
@cwlacewe
Merge branch 'master' into test_update
5aaed7b
@cwlacewe
Merge branch 'master' into test_update
d76696b
@cwlacewe
Update format
56212e3
@cwlacewe
Merge branch 'master' into test_update
c110ac8
@vercel Vercel
Copy link

vercel bot commented Dec 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 11:20pm

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. community Related to langchain-community Ɑ: vector store Related to vector store module 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Dec 2, 2024
@cwlacewe
Copy link
Contributor Author

cwlacewe commented Dec 4, 2024

@efriis, @ccurme,
Could someone please review this PR?

baskaryan
baskaryan reviewed Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@baskaryan baskaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update!

before fully reviewing, could you provide a bit more context? seems like there's some breaking changes, are these necessary for compatibility with the new vdms release? or are those two separate things

libs/community/langchain_community/vectorstores/vdms.py Outdated
embedding: Optional[Embeddings] = None,
collection_name: str = DEFAULT_COLLECTION_NAME, # DescriptorSet name
distance_strategy: DISTANCE_METRICS = "L2",
embedding: Embeddings,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baskaryan, this change wasn't necessary. I reverted it

@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@cwlacewe cwlacewe requested a review from baskaryan December 11, 2024 09:29
@cwlacewe
Copy link
Contributor Author

@baskaryan could you please review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baskaryan baskaryan Awaiting requested review from baskaryan

Assignees

@baskaryan baskaryan

Labels
community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder size:XXL This PR changes 1000+ lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
PR Reviews
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwlacewe @baskaryan