-
Notifications
You must be signed in to change notification settings - Fork 15.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OCI Generative AI new model and structured output support #28754
base: master
Are you sure you want to change the base?
Add OCI Generative AI new model and structured output support #28754
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raveharpaz do you want to add any tests? Seems scary to update core functionality with no tests.
Separately, would you be interested in publishing an Oracle OSS integration package (e.g., langchain-oracle
or langchain-oci
)? We've published a walkthrough on this process here:
https://python.langchain.com/docs/contributing/how_to/integrations/
We are encouraging contributors of LangChain integrations to go this route. This way we don't have to be in the loop for reviews, you're able to properly integration test the model, and you have control over versioning.
Docs would continue to be maintained in the langchain
repo.
Let me know what you think!
Hi @ccurme , thanks for the feedback
|
PR title:
community: Add new model and structured output support
PR message:
Add tests and docs:
Lint and test:
make format, make lint and make test we run successfully