Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue Multiple Paths Between IF/ELSE Branches #11646

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yihong0618
Copy link
Contributor

Summary

The logic steam answer is wrong we can not make sure which is the right answer.

close #11542 #9560 #10638 #10564,

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

…ons and Execute All Paths close langgenius#11542

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 13, 2024
@laipz8200
Copy link
Member

image

Hi, I tested this change in a simple chat flow and got a strange answer.

Here is the chat flow I used: Basic Chatflow.txt, you can copy its address and import it from the URL.

@yihong0618
Copy link
Contributor Author

let me fix it

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618
Copy link
Contributor Author

image Hi, I tested this change in a simple chat flow and got a strange answer.

Here is the chat flow I used: Basic Chatflow.txt, you can copy its address and import it from the URL.

try to fix it, can you test again

@laipz8200
Copy link
Member

I just changed the content in the Answer node, and the problem is still present.

image

@yihong0618 yihong0618 marked this pull request as draft December 15, 2024 09:17
@yihong0618
Copy link
Contributor Author

not quite the root cause its hard, so draft it for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Paths Between IF/ELSE Branches Invalidate Conditions and Execute All Paths
2 participants