Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature to cancel ongoing XHR request if component unloaded #94

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Feature to cancel ongoing XHR request if component unloaded #94

wants to merge 4 commits into from

Conversation

SteJaySulli
Copy link
Contributor

  • On very dynamic pages, the component could be unloaded while an XHR is ongoing
  • In these circumstances and error is displayed to the console
  • This is largely cosmetic; the error doesn't break functionality
  • See https://github.com/axios/axios#cancellation for implementation details

@SteJaySulli
INITIAL: Feature to cancel ongoing XHR request if component unloaded
06ccb69 
- On very dynamic pages, the component could be unloaded while an XHR is ongoing
- In these circumstances and error is displayed to the console
- This is largely cosmetic; the error doesn't break functionality
- See https://github.com/axios/axios#cancellation for implementation details
dextermb
dextermb suggested changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@dextermb dextermb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice idea. It'd remove the error/warning for trying to set state for unmounted components.

src/AjaxDynamicDataTable.jsx Outdated Show resolved Hide resolved
src/AjaxDynamicDataTable.jsx Outdated Show resolved Hide resolved
src/AjaxDynamicDataTable.jsx Outdated Show resolved Hide resolved
SteJaySulli and others added 3 commits March 13, 2020 08:47
@SteJaySulli @dextermb
Update src/AjaxDynamicDataTable.jsx
bb946f6 
Co-Authored-By: Dexter Marks-Barber <dexter@marks-barber.co.uk>
@SteJaySulli @dextermb
Update src/AjaxDynamicDataTable.jsx
412994c 
Co-Authored-By: Dexter Marks-Barber <dexter@marks-barber.co.uk>
@SteJaySulli
Moved initialisation code to constructor
cb3d87d
@SteJaySulli
Copy link
Contributor Author

Thanks @dextermb for the suggestions, I've merged these in.

@dextermb
Copy link
Contributor

@SteJaySulli Looks good other than minor style changes 👍

@SteJaySulli SteJaySulli requested a review from DivineOmega March 13, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dextermb dextermb dextermb requested changes

@DivineOmega DivineOmega Awaiting requested review from DivineOmega

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteJaySulli @dextermb