refactor: make classes accessed from language-* to public #9407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
miurahr
force-pushed
the
topic/miurahr/prep-java9-platform-module-system
branch
from
5c56c22
to
dcbc3cc
Compare
- Escalate to public
- o.l.c.TokenExpressionFactory
- o.o.l.l.Contributor(s)
- constructors
- static constants
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
miurahr
force-pushed
the
topic/miurahr/prep-java9-platform-module-system
branch
from
dcbc3cc
to
a5af1c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and motivation
Preparation for "Support Java9 Platform Module System(JPMS)" #9406
Circle CI in #9406 failed to build because it uses a snapshot version of "languagetool-core" library.
So I propose a preparation change for the JPMS support.
What problem is resolved?
#9406 changes packages from o.l.language to o.l.language.(lang) to support JPMS.
It asks "language-core" expose some classes to see from another package.
What is changes?
Further information
we can control visibility by module-info.java in future when languagetool support fully JPMS even when we escalate class to public.